This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Fix retry mechanism not sending body if first request fails before reading the body #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Even if successful by always reading the body we can make certain that the body will be sent to the server, even if the request fails before reading the body. See parent commit for further reference. Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
|
I'm creating this as a draft for now because I'm planning on changing |
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
We are declaring Go 1.14 for this library, so the new io.ReadAll function doesn't exist (yet). Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
|
Oh come on! I did run |
Never versions of golangci-lint will complain about this and we'll need to revert this commit. Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
julienduchesne
approved these changes
May 12, 2023
Co-authored-by: Julien Duchesne <julien.duchesne@grafana.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #109 we added the capability to have a retry mechanism for internal server or too many requests errors. While the logic was good, it had a very hard to reproduce bug in that if the call to
c.client.Dofails before reading the request body (e.g. a network connection issue) then all the subsequent requests will be sent with an empty body becausebodyBuffernever gets populated.This PR forces to always create a slice of bytes holding the request body, passing a new
bytes.Buffertoc.client.Do.