Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Grafana client #916

Merged
merged 1 commit into from
May 12, 2023
Merged

Bump Grafana client #916

merged 1 commit into from
May 12, 2023

Conversation

inkel
Copy link
Contributor

@inkel inkel commented May 12, 2023

This releases includes a bug fix that was causing some retried requests sending an empty body.

@inkel inkel requested a review from a team as a code owner May 12, 2023 17:33
@inkel inkel self-assigned this May 12, 2023
@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

julienduchesne
julienduchesne approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Failure is a flaky test (annotations seem to be somewhat eventually consistent)

@inkel
Copy link
Contributor Author

inkel commented May 12, 2023

Is it possible to retry the CI step that failed? I'm looking at the UI and I don't see the option 🤔

@julienduchesne
Copy link
Member

Is it possible to retry the CI step that failed? I'm looking at the UI and I don't see the option 🤔

I restarted the build. You can't restart a single pipeline

@inkel
Copy link
Contributor Author

inkel commented May 12, 2023

I couldn't restart the build either 🤔 maybe I missed something?

@julienduchesne
Copy link
Member

I couldn't restart the build either 🤔 maybe I missed something?

You may be logged out

@inkel
Copy link
Contributor Author

inkel commented May 12, 2023

🤦🏽 yup, that seemed to be the case.

@inkel inkel merged commit abef9d1 into master May 12, 2023
3 checks passed
@inkel inkel deleted the inkel/bump-grafana-client branch May 12, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienduchesne julienduchesne julienduchesne approved these changes

Assignees

@inkel inkel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inkel @julienduchesne