-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish multi-arch image with docker buildx #344
Conversation
@Clarity-89 @joanlopez @spinillos @ArturWierzbicki I've verified that this should work. Aside from possibly changing the docker version to the latest supported by CircleCI ( |
This needs to be rebased and use Drone instead of CircleCI as it looks like the build system was changed. Any comments from the maintainers? I'm happy to help with the rebase if needed. |
Yes, please! I'd be happy to review this once rebased and up-to-date with latest changes on Thanks! |
Would love to see this as well. Anything blocking it at this point? |
I personally asked @superbrothers to pull latest changes from However, as there has been no news since then, it's most likely we'll close this one in favor of #397, which I'm planning to review it & test it very soon. |
Oh, sorry. I was not aware of that. I will do it this weekend. |
Signed-off-by: Kazuki Suda <kazuki.suda@gmail.com>
72d8af8
to
62f664d
Compare
I've just done it. |
Alright, anything holding it up now? We're in the process of a Graviton migration and this is one of the few none arm64 images holding us up. |
Closing this in favor of #397 |
With this PR, the grafana-image-renderer container image is published for arm64 in addition to amd64.
I've confirmed that the container image builds and publishes correctly with the following command:
The above built image is available here. https://hub.docker.com/repository/docker/superbrothers/grafana-image-renderer
I've confirmed that the published image works fine in amd64 and arm64 environments.
REF