Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on multiple architectures #397

Closed
wants to merge 1 commit into from

Conversation

rickardp
Copy link

Currently, no ARM64 images are built. This changes the build script so that ARM64 as well as AMD64 images are built.

Disclaimer: This repo is using CircleCI instead of Github Actions to build, so I cannot test this except locally.

Fixes #7

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2023

CLA assistant check
All committers have signed the CLA.

@SuperMatt SuperMatt mentioned this pull request Feb 22, 2023
@michbeck100
Copy link
Contributor

Will this be resolved some day?

@Blefish
Copy link

Blefish commented May 31, 2023

Would be nice to have this as ARM becomes more and more popular in both desktop and cloud environments.

@der-eismann
Copy link

@joanlopez Could you review this instead of #344 to finally get this topic going? 🙂

@joanlopez
Copy link
Collaborator

@joanlopez Could you review this instead of #344 to finally get this topic going? 🙂

Sure, added to the backlog!

@AgnesToulet
Copy link
Contributor

Hello! Sorry for the delay, this PR looks good! Could you update it with latest changes from master so we can give it a 👍? Thanks!

@dtherhtun
Copy link

What should we do if the person who created the pull request is unavailable? How long should we wait before merging this PR?

@michbeck100
Copy link
Contributor

What should we do if the person who created the pull request is unavailable? How long should we wait before merging this PR?

Create a new PR with the same changes? I would offer to create one.

@AgnesToulet
Copy link
Contributor

Closed in favor of #468

@AgnesToulet AgnesToulet closed this Oct 5, 2023
@rickardp rickardp deleted the multiarch-docker branch October 5, 2023 12:39
@rickardp
Copy link
Author

rickardp commented Oct 5, 2023

Apologies for the tardiness, I somehow managed to lose the notifications for this one. Great to see it fixed finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ARM
8 participants