Datasource test button makes sure we can assume a provide write ARN #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshsahay
approved these changes
Nov 11, 2022
hwandersman
added a commit
that referenced
this pull request
Nov 17, 2022
Launching 3 new features: 1. Alarm Configuration Panel - update TwinMaker alarm thresholds from a Grafana panel 2. TwinMaker Query Editor Panel - visualize TwinMaker entity relationships through PartiQL queries 3. Athena Tabular Connector integration - list property data from an Athena table through a Get Property Value query Updates: * Bug fixes for the Scene Viewer and Video Player panels * Upgraded the GoLang AWS SDK to v1.44.139 to support new features * Updated the aws-iot-grafana-utils package to support the Query Editor * Use the open source IoT App Kit to support the Scene Viewer and Video Player panels Highlighted commits: * hide when streaming is not available * enable alerting in plugin.json * Adds the Active Camera template variable support and updates plugin to 1.0.1127.0 (#102) * Set min to 1 for max results for GetAlarm query * Knowledge Graph Integration * add batchPutPropertyValues to datasource * Updated GoLang client and handler with logic for handling Athena Data Connector components in GetPropertyValue * Update FilterQueryEditor and add OrderByEditor to be used for TabularConditions parameter * Add PropertyGroup selection to Grafana QueryEditor and update query interfaces * add tabular conditions to the query req * new appkit local build with 7 new features on * Datasource test button makes sure we can assume a provide write ARN (#123) * Update to latest UxSDK and localize ace Editor CSS to avoid grafana override * writes return an error if writer role is not configured * clear writer role when checkbox is unchecked * use plugin SDK logger for errors * update aws-sdk-go to 1.44.139 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Weston Harper <haweston@amazon.com> Co-authored-by: Harry Wandersman <hwanders@amazon.com> Co-authored-by: Todd Treece <todd.treece@grafana.com> Co-authored-by: Mukesh Sahay <muksahay@amazon.com> Co-authored-by: Ryan McKinley <ryantxu@gmail.com> Co-authored-by: Xinyi <xinyxu@amazon.com> Co-authored-by: Jonathan Wills <jdubs@amazon.com> Co-authored-by: Divya Kamath <divyasr@amazon.com> Co-authored-by: Mohamed Elmuhtadi <moelmu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the plugin datasource save & test button (along with any other use of GetSessionToken) make sure the write ARN is a valid arn. Doesn't verify that it has write permissions, just that it can assume the provided ARN.