Writer role fixes #126
Merged
Writer role fixes #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwandersman
approved these changes
Nov 14, 2022
toddtreece
commented
Nov 14, 2022
| @@ -176,7 +176,7 @@ func TestFetchAWSData(t *testing.T) { | |||
| PropertyFilter: []models.TwinMakerPropertyFilter{ | |||
| { | |||
| Name: "alarm_status", | |||
| Value: "ACTIVE", | |||
| Value: models.TwinMakerFilterValue{StringValue: aws.String("ACTIVE")}, | |||
There was a problem hiding this comment.
for some reason lint was failing:
+ mage -v lint
Running target: Lint
exec: golangci-lint "run" "./..."
pkg/plugin/twinmaker/client_test.go:179:13: cannot use "ACTIVE" (untyped string constant) as models.TwinMakerFilterValue value in struct literal (typecheck)
Value: "ACTIVE",
^
Error: running "golangci-lint run ./..." failed with exit code 1
toddtreece
commented
Nov 14, 2022
| @@ -186,7 +186,7 @@ func TestFetchAWSData(t *testing.T) { | |||
| }) | |||
|
|
|||
| t.Run("athena connector test no filter", func(t *testing.T) { | |||
| // t.Skip() | |||
| t.Skip() | |||
There was a problem hiding this comment.
this was failing locally. i assume it should be skipped since it requires credentials?
There was a problem hiding this comment.
yes this should be skipped
hwandersman
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define write permissions for Alarm Configuration Panelcheckbox is unchecked