Update GetSessionToken error logging #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
toddtreece
commented
Nov 14, 2022
| _, err := c.writerService() | ||
| if err != nil { | ||
| return nil, err | ||
| if c.tokenRoleWriter != "" { |
There was a problem hiding this comment.
failing early if the writer role is not configured
toddtreece
commented
Nov 14, 2022
| @@ -534,31 +534,26 @@ func (c *twinMakerClient) GetSessionToken(ctx context.Context, duration time.Dur | |||
| } | |||
|
|
|||
| func (c *twinMakerClient) GetWriteSessionToken(ctx context.Context, duration time.Duration, workspaceId string) (*sts.Credentials, error) { | |||
| _, err := c.writerService() | |||
There was a problem hiding this comment.
is this writerService call needed? it seems like GetWriteSessionToken handles assuming the role
There was a problem hiding this comment.
I don't think. This was just mirroring the other getsession function really.
toddtreece
commented
Nov 14, 2022
| // Print the error, cast err to awserr.Error to get the Code and | ||
| // Message from an error. | ||
| fmt.Println(err.Error()) | ||
| log.DefaultLogger.Error("error getting session token", "code", aerr.Code(), "error", aerr) |
There was a problem hiding this comment.
@haweston i updated this to use the grafana plugin SDK logger. it seems like having the code might be useful info in all cases where the info is available, so i added a code field
There was a problem hiding this comment.
Okay, yeah that's definitely better.
haweston
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.