New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix equality test for tokenRoleWrite exists #132

Merged

haweston merged 1 commit into 11172022_Release from writeTokenExistFix

Nov 15, 2022

Collaborator

haweston commented Nov 15, 2022

Reverse existence check made save & test for Write ARNs always fail.


          fix equality test for tokenRoleWrite exists

1284a9f

toddtreece approved these changes

View reviewed changes

toddtreece reviewed

View reviewed changes

pkg/plugin/twinmaker/client.go

               }
               func (c *twinMakerClient) GetWriteSessionToken(ctx context.Context, duration time.Duration, workspaceId string) (*sts.Credentials, error) {
-              	if c.tokenRoleWriter != "" {
+              	if c.tokenRoleWriter == "" {

Member

toddtreece Nov 15, 2022

🤦 i must have not rebuilt the backend after that change

haweston merged commit f0e97b4 into 11172022_Release

toddtreece deleted the writeTokenExistFix branch

November 16, 2022 00:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment