Render property display name #137
Conversation
|
|
Digized
force-pushed
the
propertyDisplayName
branch
from
c43b78c
to
42a0b35
Compare
pkg/models/query.go
Outdated
| // TwinMakerQuery model | ||
| type TwinMakerQuery struct { | ||
| GrafanaLiveEnabled bool `json:"grafanaLiveEnabled,omitempty"` | ||
| IsStreaming bool `json:"isStreaming,omitempty"` | ||
| WorkspaceId string `json:"workspaceId,omitempty"` | ||
| EntityId string `json:"entityId,omitempty"` | ||
| Properties []*string `json:"properties,omitempty"` | ||
| Properties []*TwinmakerPropertyInfo `json:"properties,omitempty"` |
There was a problem hiding this comment.
This change seems like it would break any existing saved dashboards 🤔
There was a problem hiding this comment.
nice catch, any suggestion as to how I should handle it.
| @@ -263,12 +263,20 @@ export class QueryEditor extends PureComponent<Props, State> { | |||
| onPropertiesSelected = (sel: Array<SelectableValue<string>>) => { | |||
| const { onChange, query, onRunQuery } = this.props; | |||
| let properties: string[] = []; | |||
| let propertyDisplayNames: { [key: string]: string } = {}; | |||
There was a problem hiding this comment.
@Digized -- is this the part you expect to do the migration? I think this will only work when in edit mode, but not from a read only saved dashbaord
There was a problem hiding this comment.
if a customer has already created a dashboard before updating the plugin:
for all the dashboards created previously, they would still see the propertyName.
when a new dashboard is added, if it has propertyDisplayName, then we use the propertyDisplayName.
just fyi, propertyDisplayName is an optional field.
There was a problem hiding this comment.
i get it now :) i added a suggestion for comment in the golang side
Co-authored-by: Ryan McKinley <ryantxu@gmail.com>
Twinmaker is adding a property displayName field. This pr is to render the property display name in the grafana plugin.