Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UxSDK and Fix TwinMaker Query Editor panel hight resize #170

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

MO-Elmu
Copy link
Collaborator

@MO-Elmu MO-Elmu commented Feb 17, 2023

What this PR does / why we need it:

  • Upgrade to the latest UxSDK version IotRociUxSDK-JS-Bundled release version 1.0.1537.0
  • Fix AWS IoT TwinMaker Query Editor Panel height and resize issue.

Which issue(s) this PR fixes:

  • Height of the Query Editor panel changes automatically on running a query and also on switching between the tabs (Visual Graph, Query Results and Summary). Resizing is not working as expected and has no value as the panel automatically changes its height.(SIM IOTROCI-9462)

Fixes #

Special notes for your reviewer:

@github-actions
Copy link

Backend code coverage report for PR #170
No changes

@github-actions
Copy link

Frontend code coverage report for PR #170

Plugin Main PR Difference
src 44.59% 44.59% 0%

@github-actions
Copy link

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/e2e-selectors@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@9.3.6...
✔ Found @grafana/data version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@9.3.6...
✔ Found @grafana/ui version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@9.3.6...
✔ Found @grafana/runtime version 8.4.11 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@9.3.6...
✔ Found @grafana/e2e-selectors version 8.4.11 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/e2e-selectors

@iwysiu
Copy link
Contributor

iwysiu commented Feb 21, 2023

Hi @MO-Elmu ,

I may be building it incorrectly, but when I tried to build the plugin I got the warning:

WARNING in ./panels/query-editor/QueryEditor.tsx 5:45-57
export 'QueryBuilder' (imported as 'QueryBuilder') was not found in 'aws-iot-twinmaker-grafana-utils

and when I tried to use the query editor panel, I got this error:
Screen Shot 2023-02-21 at 11 31 07 AM

@MO-Elmu
Copy link
Collaborator Author

MO-Elmu commented Feb 21, 2023

Hi @iwysiu,
This error tells me you are using the old UxSDK zip (aws-iot-twinmaker-grafana-utils-1.0.0.tgz)in the libs folder. part of this PR I updated this zip file, the old file the exported component was named QueryEditor but in the new version it is named QueryBuilder and this is exactly the same error you are facing.

Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I had to clear out my dependencies. Approved!

@MO-Elmu
Copy link
Collaborator Author

MO-Elmu commented Feb 22, 2023

Thanks,

@MO-Elmu MO-Elmu merged commit 903b53e into main Feb 22, 2023
@MO-Elmu MO-Elmu deleted the newUxSDK_TMQueryEditorPanel branch February 22, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants