Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale factor setting #109

Closed
wants to merge 1 commit into from
Closed

Add scale factor setting #109

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 31, 2023

Implementation copied from #77

Implementation copied from grafana#77
@CLAassistant
Copy link

CLAassistant commented May 31, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ghost ghost mentioned this pull request May 31, 2023
@schmidp
Copy link

schmidp commented Jul 25, 2023

This is exactly what I am looking for as well, will this be merged?

@briangann
Copy link
Collaborator

it will be merged, just need to test it out to verify it is working as intended

@briangann briangann self-requested a review July 25, 2023 22:09
@schmidp
Copy link

schmidp commented Aug 17, 2023

I have checked out nils-vixel:main on my Mac and ran make -l copied the linux_armv7 to a RPi4:

no scale-factor on config:

missing

1.5:

1 5

2.0:

2 0

@briangann
Copy link
Collaborator

will need to redo this PR, the submitter has deleted their account before signing the CLA

@briangann briangann self-assigned this Nov 29, 2023
@swilliams-mainstreet
Copy link

What still needs to be done here? I would be happy to help - I am new to open-source projects, though.

@wizardofdevops
Copy link
Contributor

https://github.com/grafana/grafana-kiosk/pull/120/files

I just opened another PR since our hero went AWOL.

@briangann
Copy link
Collaborator

Fixed by PR #120

@briangann briangann closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants