Window size setting. #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The scaling does not always work properly. Not all the elements are scaled. This particular element was working and then just stopped working. |
|
let me test this out, i have seen this also on some dashboards. |
briangann
reviewed
Oct 12, 2022
| @@ -44,6 +46,8 @@ func ProcessArgs(cfg interface{}) Args { | |||
| f.StringVar(&a.Mode, "kiosk-mode", "full", "Kiosk Display Mode [full|tv|disabled]\nfull = No TOPNAV and No SIDEBAR\ntv = No SIDEBAR\ndisabled = omit option\n") | |||
| f.StringVar(&a.URL, "URL", "https://play.grafana.org", "URL to Grafana server") | |||
| f.StringVar(&a.WindowPosition, "window-position", "0,0", "Top Left Position of Kiosk") | |||
| f.StringVar(&a.WindowPosition, "window-size", "1920,1080", "Size of Kiosk in pixels") | |||
There was a problem hiding this comment.
this variable should be a.WindowSize or it will overwrite the position setting and not set the size
briangann
requested changes
Oct 12, 2022
|
this has been implemented/merged as part of PR #102 |
|
The zoom scaling factor, chrome flag |
ghost
pushed a commit
to koliyo/grafana-kiosk
that referenced
this pull request
May 31, 2023
Implementation copied from grafana#77
ghost
mentioned this pull request
|
New PR here for scaling factor: #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.