fix secretkeyref omitempty wrong symbol causing invalid crd field generation #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhaddon this should fix the issue for you |
|
Looks like we're hitting rate limiting on CI, nothing to be concerned about, will re-run after approvals |
pb82
reviewed
Aug 17, 2023
| @@ -113,7 +113,7 @@ type GrafanaDashboardEnv struct { | |||
| Name string `json:"name"` | |||
| // Inline evn value | |||
There was a problem hiding this comment.
Hmm, maybe it's time for us to run a spell checker on the entire repo 😅
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a wrong symbol used for tag splitting, this caused the field to be assigned the name of
value:omitempty, rather than what the intent was, to assign the namevalueand add an omitempty call in the json tag.