Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostnetwork #380

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Hostnetwork #380

merged 3 commits into from
Mar 29, 2021

Conversation

alrf
Copy link

@alrf alrf commented Mar 29, 2021

Description

Added hostNetwork option and DNSPolicy which will be accordingly changed (DNSPolicy: ClusterFirst by default and DNSPolicy: ClusterFirstWithHostNet for hostNetwork: true)

Relevant issues/tickets

#374

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

@openshift-ci-robot
Copy link

Hi @alrf. Thanks for your PR.

I'm waiting for a integr8ly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alrf
Copy link
Author

alrf commented Mar 29, 2021

/assign @pb82

Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Verified on both clean install and upgrade scenarios, all seems to be working fine, hostNetwork is propagated to the pod spec, thanks for contributing @alrf 👍

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HubertStefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HVBE
Copy link
Collaborator

HVBE commented Mar 29, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2021

@alrf: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/images 496569a link /test images
ci/prow/format 496569a link /test format
ci/prow/unit 496569a link /test unit
ci/prow/e2e 496569a link /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HVBE
Copy link
Collaborator

HVBE commented Mar 29, 2021

Merging manually, verified locally, CI still seems to be flaky, going to investigate later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants