-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hostnetwork #380
Hostnetwork #380
Conversation
Hi @alrf. Thanks for your PR. I'm waiting for a integr8ly member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @pb82 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Verified on both clean install and upgrade scenarios, all seems to be working fine, hostNetwork is propagated to the pod spec, thanks for contributing @alrf 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HubertStefanski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@alrf: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Merging manually, verified locally, CI still seems to be flaky, going to investigate later on |
Description
Added
hostNetwork
option andDNSPolicy
which will be accordingly changed (DNSPolicy: ClusterFirst
by default andDNSPolicy: ClusterFirstWithHostNet
forhostNetwork: true
)Relevant issues/tickets
#374
Type of change
Checklist
Verification steps