-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change maxUnavailable and MaxSurge to use percentages as opposed to int #383
Conversation
/closes #381 |
var maxUnaval intstr.IntOrString = intstr.FromString("25%") | ||
var maxSurge intstr.IntOrString = intstr.FromString("25%") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pb82 when you can, have a quick look at this, I think it should fix the 503 between grafana restarts
/retest |
@HubertStefanski: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pb82 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CI failing because an image can't be pulled. Going to merge this manually, the change should be safe. |
Description
Fixes the rolling update strategy,
The grafana web UI should no longer return 503's when resources are added to the grafana instance
Relevant issues/tickets
Type of change
Checklist
Verification steps
deploy/examples/datasources