Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change maxUnavailable and MaxSurge to use percentages as opposed to int #383

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

HVBE
Copy link
Collaborator

@HVBE HVBE commented Mar 31, 2021

Description

Fixes the rolling update strategy,
The grafana web UI should no longer return 503's when resources are added to the grafana instance

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

  • Check out the master branch
  • Run the operator and open the web UI presented through the ingress/route
  • add datasources from deploy/examples/datasources
  • The web UI should return 503
  • Restart the operator from this branch
  • add more datasources, the web UI should no longer return 503's while the operator adds datasources

@HVBE HVBE added this to In progress in Grafana Operator (Kanban) via automation Mar 31, 2021
@HVBE
Copy link
Collaborator Author

HVBE commented Mar 31, 2021

/closes #381

@HVBE HVBE linked an issue Mar 31, 2021 that may be closed by this pull request
Comment on lines +119 to +120
var maxUnaval intstr.IntOrString = intstr.FromString("25%")
var maxSurge intstr.IntOrString = intstr.FromString("25%")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pb82 when you can, have a quick look at this, I think it should fix the 503 between grafana restarts

@HVBE
Copy link
Collaborator Author

HVBE commented Apr 5, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Apr 5, 2021

@HubertStefanski: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/format 40adcb2 link /test format
ci/prow/images 40adcb2 link /test images
ci/prow/e2e 40adcb2 link /test e2e
ci/prow/unit 40adcb2 link /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Grafana Operator (Kanban) automation moved this from In progress to Reviewer approved Apr 8, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pb82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pb82
Copy link
Collaborator

pb82 commented Apr 8, 2021

CI failing because an image can't be pulled. Going to merge this manually, the change should be safe.

@pb82 pb82 merged commit ca8ba68 into grafana:master Apr 8, 2021
Grafana Operator (Kanban) automation moved this from Reviewer approved to Done Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Generated grafana deployment cannot be upgraded without downtime
3 participants