Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change maxUnavailable and MaxSurge to use percentages as opposed to int #383

Merged
merged 1 commit into from
Apr 8, 2021
Merged

change maxUnavailable and MaxSurge to use percentages as opposed to int #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/controller/model/grafanaDeployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ func getReplicas(cr *v1alpha1.Grafana) *int32 {
}

func getRollingUpdateStrategy() *v1.RollingUpdateDeployment {
var maxUnaval intstr.IntOrString = intstr.FromInt(25)
var maxSurge intstr.IntOrString = intstr.FromInt(25)
var maxUnaval intstr.IntOrString = intstr.FromString("25%")
var maxSurge intstr.IntOrString = intstr.FromString("25%")
Comment on lines +119 to +120
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pb82 when you can, have a quick look at this, I think it should fix the 503 between grafana restarts

return &v1.RollingUpdateDeployment{
MaxUnavailable: &maxUnaval,
MaxSurge: &maxSurge,
Expand Down