Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Fix typo subscriptionId #391

Merged
merged 1 commit into from
Apr 12, 2021
Merged

.Fix typo subscriptionId #391

merged 1 commit into from
Apr 12, 2021

Conversation

1nd2rd3st
Copy link

Description

There is a typo for the Azure datasource field subscriptionId which prevents the operator of parsing the datasource correctly

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Verification steps

@openshift-ci-robot
Copy link

Hi @1nd2rd3st. Thanks for your PR.

I'm waiting for a integr8ly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@1nd2rd3st
Copy link
Author

/assign @pb82

@openshift-ci-robot openshift-ci-robot assigned pb82 and unassigned pb82 Apr 12, 2021
Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@1nd2rd3st good spot, thanks for addressing 👍

@openshift-ci
Copy link

openshift-ci bot commented Apr 12, 2021

@1nd2rd3st: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/images a0556d5 link /test images
ci/prow/format a0556d5 link /test format
ci/prow/e2e a0556d5 link /test e2e
ci/prow/unit a0556d5 link /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HubertStefanski, pb82

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [HubertStefanski,pb82]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pb82
Copy link
Collaborator

pb82 commented Apr 12, 2021

Good catch, thanks @1nd2rd3st
Merging manually

@pb82 pb82 merged commit 828b99f into grafana:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants