Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role_attribute_strict flag in generic/okta oauth config #499

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

4n4nd
Copy link
Contributor

@4n4nd 4n4nd commented Aug 12, 2021

Description

Add role_attribute_strict bool flag in the generic and okta oauth configs.
This was added in upstream grafana in the following PR: grafana/grafana#28021

Relevant issues/tickets

Resolves #498

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

  1. Deploy Operator
  2. Deploy Grafana
  3. Add the following in grafana resource
config:
    auth.generic_oauth:
      enabled: true
      role_attribute_strict: true
  1. The created grafana container should have a grafana.ini with the following string role_attribute_strict: true

@4n4nd 4n4nd changed the title Add role_attribute_strict flag in generic oauth config Add role_attribute_strict flag in generic/okta oauth config Aug 12, 2021
Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

Thanks for contributing @4n4nd 👍 , changes work as expected, the configmap is populated with the values defined in the example

@HVBE HVBE merged commit dddda0e into grafana:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add role_attribute_strict to auth.generic_oauth
2 participants