Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication via Openshift to Grafana #37

Closed
HumairAK opened this issue Nov 25, 2020 · 11 comments · Fixed by #891
Closed

Add authentication via Openshift to Grafana #37

HumairAK opened this issue Nov 25, 2020 · 11 comments · Fixed by #891
Assignees

Comments

@HumairAK
Copy link
Member

The default access should be read only for users.

@HumairAK HumairAK self-assigned this Nov 25, 2020
@HumairAK
Copy link
Member Author

HumairAK commented Dec 1, 2020

I have a prototype example here that uses dex to add auth to grafana. We can assign grafana roles based on openshift groups using this method. Downside is we have to deploy a separate instance of dex to do this.

@anishasthana
Copy link
Member

Doesn't really seem like there are any downsides to me. This way our monitoring graphs and stuff can be open for anyone to look at, but only we have edit rights on stuff. An additional dex server isn't that bad

@tumido
Copy link
Member

tumido commented Dec 8, 2020

TBH, we'll need DEX for Argo as well and maybe for other components. Think, instead of deploying DEX along with every component, we should rather leverage the ArgoCD's DEX or have one common DEX deployment with multiple static clients. WDYT?

#39

@HumairAK
Copy link
Member Author

HumairAK commented Dec 8, 2020

I have been thinking the exact same thing @tumido -- we should try to use one instance. ArgoCD has some integrations with dex so let's wait on moving that one to use the external one. But we should start by having grafana/argo and others using this central one then moving argocd there as well.

I haven't played around with having dex in a separate namespace yet, but it should be straight forward.

@HumairAK
Copy link
Member Author

HumairAK commented Dec 8, 2020

I'm guessing we can use dex with superset too.

@tumido
Copy link
Member

tumido commented Dec 8, 2020

I can take care of it. 👍 I'll file an issue for myself. I have a POC ready for Argo, you have one for Grafana, so I combine it together... WDYT? 🙂

@tumido
Copy link
Member

tumido commented Dec 8, 2020

Yeah, we can hook Superset to it and I'm sure Hue as well. It's more user friendly than Openshift itself. 😄

@HumairAK
Copy link
Member Author

HumairAK commented Dec 8, 2020

Yeah go for it, if you have any questions about the grafana stuff feel free to ask.

@HumairAK
Copy link
Member Author

HumairAK commented Dec 8, 2020

Can we add it under operate-first/apps under a separate folder dex that's outside of odh.

@HumairAK HumairAK changed the title Add Openshift Authentication for Grafana Add authentication via Openshift to Grafana Dec 8, 2020
@HumairAK
Copy link
Member Author

HumairAK commented Jan 18, 2021

more authorization related, but is relevant I think:

if we can, we should also see about limiting access to editing datasources. Discussion here

@HumairAK
Copy link
Member Author

PR by @4n4nd to add role_attribute_strict attribute to grafana operator: grafana/grafana-operator#499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants