Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve configurability of probes #636

Merged
merged 2 commits into from
Nov 30, 2021
Merged

improve configurability of probes #636

merged 2 commits into from
Nov 30, 2021

Conversation

pb82
Copy link
Collaborator

@pb82 pb82 commented Nov 30, 2021

Description

Makes readiness and liveness probes more configurable and also adds an option to set the scheme.

Relevant issues/tickets

#635

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

  1. Deploy the operator
  2. Create a Grafana CR and override the readiness and liveness probes to set their scheme to https

@vmanley
Copy link
Contributor

vmanley commented Nov 30, 2021

Verified as per steps provided on CRC

@NissesSenap
Copy link
Collaborator

You need to perform make test or you can run make bundle-kustomization. It will update the changes that is breaking the pr.
But always good to run make test since it includes a number of other commands as well that makes sure that all files is up to date.

@NissesSenap NissesSenap self-requested a review November 30, 2021 17:15
Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NissesSenap NissesSenap merged commit d60ea53 into master Nov 30, 2021
@NissesSenap NissesSenap deleted the probe-scheme branch November 30, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants