Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist fields for Grafana Clickhouse datasource #696

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Whitelist fields for Grafana Clickhouse datasource #696

merged 1 commit into from
Mar 8, 2022

Conversation

daha
Copy link
Contributor

@daha daha commented Mar 4, 2022

Description

Whitelist the jsonData fields used by the grafana-clickhouse-datasource.

Relevant issues/tickets

Type of change

I'm not sure if this is breaking or not. It whitelists 3 fields in jsonData in the datasource CRD.

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

HVBE
HVBE approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@HVBE HVBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this @daha

@HVBE HVBE merged commit 23fae17 into grafana:master Mar 8, 2022
@daha daha mentioned this pull request Mar 8, 2022
Closed
@daha daha deleted the whitelist-grafana-clickhouse-datasource-config branch March 31, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HVBE HVBE HVBE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daha @HVBE