-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for auth.jwt in config #876
feat: add support for auth.jwt in config #876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for even more PR:s :)
There is some config that I can't find in the docs.
I haven't read through the grafana code though so there might be stuff missing in the docs.
I don't have time to take a deeper look now though.
Can you please share where you found it.
auto_sign_up = true | ||
cache_ttl = 60m | ||
email_claim = sub | ||
enable_login_token = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to find enable_login_token in https://grafana.com/docs/grafana/latest/setup-grafana/configure-security/configure-authentication/jwt/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NissesSenap
Same thing as my previous PR, I've found all the config here: https://github.com/grafana/grafana/blob/main/conf/sample.ini
key_file = /path/to/key.pem | ||
role_attribute_path = Viewer | ||
role_attribute_strict = true | ||
skip_org_role_sync = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also unable to find skip_org_role_sync
@rayanebel can you please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR will allow to configure grafana with JWT authentication by adding the required
auth.jwt
property in the config.Type of change
Checklist
Verification steps
I have added a new test case
TestCfgAuthJwt
and I've updated the testTestWrite
. I did not tried in a fresh cluster to create a Grafana instance with a validauth.jwt
config