Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic OAuth - add use_pkce field #891

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Generic OAuth - add use_pkce field #891

merged 1 commit into from
Feb 7, 2023

Conversation

maciekm
Copy link
Contributor

@maciekm maciekm commented Feb 6, 2023

Description

Very similar to #889

adds pkce support: https://grafana.com/docs/grafana/latest/setup-grafana/configure-security/configure-authentication/generic-oauth/#pkce

✅ built and tested with image: maciekm/grafana-operator:use-pkce-1

Relevant issues/tickets

#877

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

@pb82 pb82 merged commit 5b1d82e into grafana:master Feb 7, 2023
@maciekm maciekm mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants