-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic OAuth - Add Name Field #889
Generic OAuth - Add Name Field #889
Conversation
97ddf59
to
53c5887
Compare
@dhhuynh2 thanks for the PR! Seems like some of the checks are failing, you can fix that by running the commands listed at the end of those checks and pushing updates to your branch. |
@dhhuynh2 can you rebase and run |
8b2e347
to
82386e5
Compare
Just did -
|
82386e5
to
9568b49
Compare
You need to add the changes done in |
Ah, think that was added with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The name field is a supported field in the config, but is not available in this operator. Thus, it makes sense to make it available for generic OAuth.
Relevant issues/tickets
#875
Type of change
Checklist