Generic OAuth - Add Name Field

[dhhuynh2]

Description

The name field is a supported field in the config, but is not available in this operator. Thus, it makes sense to make it available for generic OAuth.

Relevant issues/tickets

#875

Type of change

• New feature (non-breaking change which adds functionality)

Checklist

• This change requires a documentation update
• I have added tests that prove my fix is effective or that my feature works
• I have added a test case that will be used to verify my changes
• Verified independently on a cluster by reviewer

[weisdd]

@dhhuynh2 thanks for the PR! Seems like some of the checks are failing, you can fix that by running the commands listed at the end of those checks and pushing updates to your branch.

[dhhuynh2]

@dhhuynh2 thanks for the PR! Seems like some of the checks are failing, you can fix that by running the commands listed at the end of those checks and pushing updates to your branch.

Sorry about that @weisdd - hadn't run make fmt.

0ddb600

Should be good for another look.

[NissesSenap]

@dhhuynh2 can you rebase and run make test as well. After that I think the CI should be passing without any issues.

[dhhuynh2]

@dhhuynh2 can you rebase and run make test as well. After that I think the CI should be passing without any issues.

Just did - make test looked fine locally.

...
?   	github.com/grafana-operator/grafana-operator/v4	[no test files]
?   	github.com/grafana-operator/grafana-operator/v4/api	[no test files]
ok  	github.com/grafana-operator/grafana-operator/v4/api/integreatly/v1alpha1	0.444s	coverage: 2.9% of statements
ok  	github.com/grafana-operator/grafana-operator/v4/controllers	0.214s	coverage: [no statements] [no tests to run]
?   	github.com/grafana-operator/grafana-operator/v4/controllers/common	[no test files]
ok  	github.com/grafana-operator/grafana-operator/v4/controllers/config	1.236s	coverage: 36.2% of statements
?   	github.com/grafana-operator/grafana-operator/v4/controllers/constants	[no test files]
ok  	github.com/grafana-operator/grafana-operator/v4/controllers/grafana	0.430s	coverage: 6.0% of statements
ok  	github.com/grafana-operator/grafana-operator/v4/controllers/grafanadashboard	1.296s	coverage: 2.1% of statements
ok  	github.com/grafana-operator/grafana-operator/v4/controllers/grafanadashboardfolder	0.713s	coverage: 4.7% of statements
?   	github.com/grafana-operator/grafana-operator/v4/controllers/grafanadatasource	[no test files]
ok  	github.com/grafana-operator/grafana-operator/v4/controllers/grafananotificationchannel	1.062s	coverage: 21.3% of statements
ok  	github.com/grafana-operator/grafana-operator/v4/controllers/model	0.353s	coverage: 36.0% of statements
?   	github.com/grafana-operator/grafana-operator/v4/internal/k8sutil	[no test files]
?   	github.com/grafana-operator/grafana-operator/v4/version	[no test files]

[NissesSenap]

You need to add the changes done in deploy/manifests/latest/crds.yaml as well.
I have now fixed it and pushed the changes.

[dhhuynh2]

You need to add the changes done in deploy/manifests/latest/crds.yaml as well. I have now fixed it and pushed the changes.

Ah, think that was added with make fmt at some point. Thanks for correcting.

[NissesSenap]

LGTM