Example: adding tests to verify the basic app #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckn
commented
Sep 15, 2022
examples/app-basic/src/plugin.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "$schema": "https://raw.githubusercontent.com/grafana/grafana/master/docs/sources/developers/plugins/plugin.schema.json", | |||
| "type": "app", | |||
| "name": "Basic App", | |||
| "id": "basic-app", | |||
| "id": "grafana-basic-app", | |||
There was a problem hiding this comment.
Prefixing with grafana- to remove risk of colliding.
There was a problem hiding this comment.
Isn't the prefix of a plugin id be the org name? Maybe swap it out for myOrg?
"id": "myorg-basic-app",
academo
approved these changes
Sep 21, 2022
jackw
approved these changes
Sep 21, 2022
|
|
||
| describe('configurating app', () => { | ||
| beforeEach(() => { | ||
| cy.visit('http://localhost:3000/plugins/grafana-basic-app'); |
There was a problem hiding this comment.
We should be able to improve this with a flow to e2e package or some such.
There was a problem hiding this comment.
I totally agree! Lets add it to the list to expose some kind of function that will fetch this based on the environment we are running the tests in.
examples/app-basic/cypress/integration/02-app-navigation.spec.ts
Outdated
Show resolved
Hide resolved
examples/app-basic/src/plugin.json
Outdated
| @@ -2,7 +2,7 @@ | |||
| "$schema": "https://raw.githubusercontent.com/grafana/grafana/master/docs/sources/developers/plugins/plugin.schema.json", | |||
| "type": "app", | |||
| "name": "Basic App", | |||
| "id": "basic-app", | |||
| "id": "grafana-basic-app", | |||
There was a problem hiding this comment.
Isn't the prefix of a plugin id be the org name? Maybe swap it out for myOrg?
"id": "myorg-basic-app",
Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably be good enough to verify that this app is working as expected. I renamed the test specs in the datasource to be consistent with the rest of the spec files in the repo.
Fixes: #53 #12