Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Add Darksky API plugin #301

Merged
merged 2 commits into from
Sep 29, 2018
Merged

Add Darksky API plugin #301

merged 2 commits into from
Sep 29, 2018

Conversation

andig
Copy link
Contributor

@andig andig commented Aug 31, 2018

DarkSky Datasource - weather and forecast data for Grafana

This plugin allows to history weather conditions and forecast data as returned by the DarkSky API.

dashboard

Requirements

  1. API key

    Register for a DarkSky API key at DarkSky. The free plan will allow 1000 API calls per day.

  2. Geo location

    Weather data will be available for the location defined when creating the data source. If unsure you can alwayds use Google Maps or IP location APIs like ipgeolocation.io.

Configuration

Example configuration:

config

@andig
Copy link
Contributor Author

andig commented Aug 31, 2018

CI fails on unrelated plugin

@andig
Copy link
Contributor Author

andig commented Sep 13, 2018

Hello @daniellee can we have an update on this one please?
Thanks

@andig
Copy link
Contributor Author

andig commented Sep 18, 2018

After 18 days since first asking and 5 days since pinging I'm starting what it would take to get a response. Sorry to say that- but together with my experience with the simplejson plugin- I feel that Grafana (at least the plugin part of the ecosystem) is really unwelcoming.

@andig
Copy link
Contributor Author

andig commented Sep 24, 2018

Ping @torkelo @daniellee it has now been 24 days without any sign of communication. Is there a particular reason that this plugin request doesn‘t deserve an answer? If so it would be nice to know about it so I can stop trying...

@marefr
Copy link
Member

marefr commented Sep 25, 2018

Sorry for not getting back to you. Thought this build failed due to a real linting error. Seems like it fails with an unhandled exception. We need to investigate and we'll let you know when we know what's wrong. Thanks

@DanCech
Copy link
Contributor

DanCech commented Sep 25, 2018

The problem is that the plugin id is not valid https://github.com/andig/grafana-darksky/blob/master/dist/plugin.json#L3

The plugin id should be andig-darksky-datasource (assuming your grafana.com username is andig also). You'll need to update your repo with the correct id in plugin.json, then update this PR with the correct plugin id and the updated commit hash.

@andig
Copy link
Contributor Author

andig commented Sep 25, 2018

Thanks @DanCech the failure wasn't obvious. I've updated accordingly.

@DanCech
Copy link
Contributor

DanCech commented Sep 25, 2018

It looks like you manually modified dist/plugin.json. What you'll want to do is to update src/plugin.json then re-run npm build to update dist/

@marefr marefr self-assigned this Sep 25, 2018
@andig
Copy link
Contributor Author

andig commented Sep 26, 2018

Too many things at once, sorry for the shortcut. Updated again.

@andig
Copy link
Contributor Author

andig commented Sep 28, 2018

ping :)

@daniellee daniellee merged commit 28e173d into grafana:master Sep 29, 2018
@daniellee
Copy link
Contributor

Merged and published: https://grafana.com/plugins/andig-darksky-datasource

I apologize for the lack of response - most of the plugin work falls on me and I just haven't had time in the last few weeks. I will try and spread it out and get more people involved in the reviewing process.

The plugin is nice and simple and seems to be bug free - nice work!

@daniellee
Copy link
Contributor

daniellee commented Sep 29, 2018

Just noticed that this sentence in the README is a bit strange:

This plugin allows to history weather conditions and forecast data as returned by the DarkSky API.

Maybe This plugin allows you to graph historical weather conditions and forecast data...

@andig andig deleted the 1.0.0 branch September 30, 2018 09:21
@andig
Copy link
Contributor Author

andig commented Sep 30, 2018

I apologize for the lack of response - most of the plugin work falls on me and I just haven't had time in the last few weeks. I will try and spread it out and get more people involved in the reviewing process.

I have to admit it was a bit painful. I'm wondering why you need to maintain such a level of control. If you look at e.g. node-red it's much easier to install plugins. If it is for grafana cloud- it might make sense to enforce this review procedure only for allowing plugins into the hosted Grafana?

Just noticed that this sentence in the README is a bit strange:

Thanks for the hint, will fix that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants