-
Notifications
You must be signed in to change notification settings - Fork 266
Add cloudspout-button-panel #658
Add cloudspout-button-panel #658
Conversation
Thank you @derjust for contributing your plugin to Grafana! I've tested your panel and have a few comments. Please fixThese are things that might negatively impact the user experience, and should be fixed.
Please consider fixingThese are recommendations that will improve the quality of the plugin, but aren't required for publishing the plugin.
|
Thanks for the review
✅
✅
Removed those - they seemed to be not styled ✅
✅
This would make it way more flexible; I agree with that.
Let me check again. Couldn't reproduce this yesterday |
Addressingg the review comments from grafana/grafana-plugin-repository#658 allowing for a unlimited number of key/value pairs for Header/Query parameters
Addressed also the last point to have a dynamic list of parameters for query/parameters & release a new version of the plugin |
Could you look at resolving these conflicts? |
Please consider adding cloudspout-button-panel to the plugin repository. It provides a simple panel that shows only one button - to integrate with any kind of HTTP/REST API: * Support GET and POST HTTP verb * Adds no new javascript dependencies * Uses standard browser APIs and respects CORS * Support API key via header X-API-Key or query parameter ?api-key * Custom label text & Grafana template design
Version 7.0.2 of the plugin addresses the review comments
Version 7.0.2 of the plugin addresses the review comments and removed dead code
Version 7.0.3 of the plugin addresses the review comments and removed dead code
91338f5
to
459f832
Compare
Rebased & fixed conflict |
Thank you! |
Please consider adding cloudspout-button-panel to the plugin repository.
It provides a simple panel that shows only one button - to integrate with any kind of HTTP/REST API: