Data: (Breaking) Change Enum field type to contain EnumItem #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
approved these changes
Feb 27, 2023
kylebrandt
added
dataframe
area/dataplane
ryantxu
approved these changes
Feb 28, 2023
kylebrandt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into changing EnumVector to contain EnumItems, so the vector type can be known from the type of a single item.
This makes FieldTypeFor and data.NewField work with enums, #581 (comment)
This is a breaking change since before this field would be passed
unit16and is now passed adata.EnumItemIndexinstead. But from discussing with Ryan this is used outside a PR right now as far as we know.