logs contract: more robust field finding, explicit approach #660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(there are two approaches, i created two PRs for the two approaches. this one, and #661. we should only merge one of them)
this PR clarifies a corner-case that can happen when finding the
timestamp
and themessage
field.(please note, both the
severity
andid
fields are string-fields, so as soon as any of these two is added to the dataframe, we will hit the "two string fields" situation.)pro: explicit about what happens when more than one string fields exist
con: non backward-compatible (for example, Loki&Elastic dataframes simply make sure the message field is the first string field)