Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs contract: more robust field finding, explicit approach #660

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

gabor
Copy link
Contributor

@gabor gabor commented Mar 30, 2023

(there are two approaches, i created two PRs for the two approaches. this one, and #661. we should only merge one of them)

this PR clarifies a corner-case that can happen when finding the timestamp and the message field.

(please note, both the severity and id fields are string-fields, so as soon as any of these two is added to the dataframe, we will hit the "two string fields" situation.)

pro: explicit about what happens when more than one string fields exist
con: non backward-compatible (for example, Loki&Elastic dataframes simply make sure the message field is the first string field)

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gabor gabor changed the title logs contract: more robust field finding logs contract: more robust field finding, explicit approach Mar 30, 2023
@gabor gabor mentioned this pull request Mar 30, 2023
@gabor gabor marked this pull request as ready for review March 30, 2023 07:52
@gabor gabor requested a review from a team as a code owner March 30, 2023 07:52
@yesoreyeram
Copy link
Contributor

I prefer this over #661

@gabor gabor enabled auto-merge (squash) April 4, 2023 11:44
@gabor gabor merged commit 93cd91d into main Apr 4, 2023
@gabor gabor deleted the gabor/logs-contract-main-fields-idea1 branch April 4, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants