logs contract: more robust field finding, backward compatible approach #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gabor
changed the title
Merged
|
I prefer the other approach which is clear on what we are doing. ( less guess work ) |
|
closing this in favor of #660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(there are two approaches, i created two PRs for the two approaches. this one, and #660. we should only merge on of them)
this PR adjusts the
timestampandmessagefield finding so that it is the same as used currently in the grafana-logs-visualization.pro: this makes it more backward compatible
con: someone can make a dataframe, where there will be 2 string fields,
idandmessage, and if theidfield goes first, it will be mistaken for the log-message-field.