httpclient: Don't forward HTTP headers by default #679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #612 enable automatic forwarding of HTTP headers did introduce problems for several plugins. This disables automatic forwarding of HTTP headers and requires
httpclient.Options.ForwardHTTPHeaders
to be configued totrue
for HTTP headers to be forwarded. This doesn't affect core Grafana plugins since we already override the default middlewares there.Consider the alternative of removing adding the
httpclient.ContextualMiddleware
tohttpclient.DefaultMiddlewares
. Then you would had to do something like thisFeels like there might be other use cases for
httpclient.ContextualMiddleware
in the future why having it as default make sense and why I opted for these changes instead.Would have to update the following if we merge: