Prepare 2.6.1 release #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Backend code coverage report for PR #233 |
|
Frontend code coverage report for PR #233 |
|
@iwysiu can you also downgrade the grafana-plugin-sdk-go to the previous version used to avoid any issue like grafana/athena-datasource#233 ? https://raintank-corp.slack.com/archives/C01LVB0CYTW/p1683130735011179 |
|
Athena data source had no issue with the freshly-released grafana-plugin-sdk-go v0.161.0 -- sorry it's a pain, but would you use that instead? |
fridgepoet
approved these changes
May 5, 2023
CHANGELOG.md
Outdated
| - Security: Upgrade Go in build process to 1.20.4 | ||
| - Revert grafana-plugin-sdk-go version to 0.149.0 to fix connection issues. Should be same behavior as behavior with no known issues. | ||
| - Update grafana-plugin-sdk-go version to 0.161.0 to fix connection issues. |
There was a problem hiding this comment.
Just a doubt here since we aren't yet aware of any connection issues in any plugin other than Athena.
Another idea would be to say that we are using 0.161.0 in order to not forward HTTP headers by default grafana/grafana-plugin-sdk-go#679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.