Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update to go 1.20 and grafana-plugin-ci 1.8.1 #713

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

yuri-tceretian
Copy link
Contributor

What this PR does / why we need it:
Updates minimal version of Go to 1.20. Because the current version 1.6.1 of grafana-plugin-ci uses Go 1.19 I had to bump the version to 1.8.1

@yuri-tceretian yuri-tceretian added type/build dev workflow Issues on development workflow dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 5, 2023
@yuri-tceretian yuri-tceretian requested a review from a team as a code owner July 5, 2023 13:52
@yuri-tceretian yuri-tceretian requested review from wbrowne and xnyo and removed request for a team July 5, 2023 13:52
@yuri-tceretian yuri-tceretian self-assigned this Jul 5, 2023
@xnyo
Copy link
Member

xnyo commented Jul 5, 2023

The new container image has a more recent version of golangci-lint as well, which has some new checks regarding unused arguments. This causes the CI pipeline to fail at the lint step.

I think I have a WIP branch somewhere where I started addressing those issues, if you want you can remove the linter causing the issue (revive) from .golangci.toml and I can take care of fixing those linter issues later 😃

@wbrowne are you okay with that?

You can disable those checks by deleting this line:

Then CI should pass

@wbrowne
Copy link
Member

wbrowne commented Jul 5, 2023

The new container image has a more recent version of golangci-lint as well, which has some new checks regarding unused arguments. This causes the CI pipeline to fail at the lint step.

I think I have a WIP branch somewhere where I started addressing those issues, if you want you can remove the linter causing the issue (revive) from .golangci.toml and I can take care of fixing those linter issues later 😃

@wbrowne are you okay with that?

You can disable those checks by deleting this line:

Then CI should pass

Yeah is probably fine 👍

@yuri-tceretian yuri-tceretian requested a review from a team as a code owner July 5, 2023 14:58
@yuri-tceretian
Copy link
Contributor Author

I fixed linter failures in the last commit. The changes are straightforward. If you think there is something else can be done, or it can be done differently, I am fine removing the last commit and keep revive rule disabled.

Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the linter issues as well! 🙏

data/frame.go Outdated Show resolved Hide resolved
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuri-tceretian yuri-tceretian merged commit a5f7ed7 into main Jul 5, 2023
2 checks passed
@yuri-tceretian yuri-tceretian deleted the yuri-tceretian/go-120 branch July 5, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file dev workflow Issues on development workflow go Pull requests that update Go code type/build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants