-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update to go 1.20 and grafana-plugin-ci 1.8.1 #713
Conversation
The new container image has a more recent version of golangci-lint as well, which has some new checks regarding unused arguments. This causes the CI pipeline to fail at the lint step. I think I have a WIP branch somewhere where I started addressing those issues, if you want you can remove the linter causing the issue ( @wbrowne are you okay with that? You can disable those checks by deleting this line: grafana-plugin-sdk-go/.golangci.toml Line 50 in 7dd9759
Then CI should pass |
Yeah is probably fine 👍 |
I fixed linter failures in the last commit. The changes are straightforward. If you think there is something else can be done, or it can be done differently, I am fine removing the last commit and keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the linter issues as well! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this PR does / why we need it:
Updates minimal version of Go to 1.20. Because the current version 1.6.1 of grafana-plugin-ci uses Go 1.19 I had to bump the version to 1.8.1