Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix flagsMapFromEnv comments #723

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

oshirohugo
Copy link
Contributor

What this PR does / why we need it:

Fix comment for flagsMapFromEnv

Which issue(s) this PR fixes:

Followup from: #722

@oshirohugo oshirohugo requested a review from a team as a code owner August 29, 2023 13:44
@oshirohugo oshirohugo requested review from wbrowne and xnyo and removed request for a team August 29, 2023 13:44
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oshirohugo oshirohugo merged commit 1e2d4da into main Aug 29, 2023
2 checks passed
@oshirohugo oshirohugo deleted the fix-comment-for-featuretoggles branch August 29, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants