Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proxy options from context #955

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Set proxy options from context #955

merged 2 commits into from
Apr 15, 2024

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented Apr 15, 2024

What this PR does / why we need it:
Simplifies the PDC route for non-HTTP datasources who want to configure a proxy connection on their datasource instance.

@wbrowne wbrowne added the enhancement New feature or request label Apr 15, 2024
@wbrowne wbrowne self-assigned this Apr 15, 2024
@wbrowne wbrowne requested a review from a team as a code owner April 15, 2024 09:34
@wbrowne wbrowne requested review from marefr, andresmgot and oshirohugo and removed request for a team April 15, 2024 09:34
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wbrowne wbrowne merged commit ac71ca4 into main Apr 15, 2024
3 checks passed
@wbrowne wbrowne deleted the proxy-from-ctx branch April 15, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants