Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to use PDC request values #799

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Make it possible to use PDC request values #799

merged 5 commits into from
Apr 15, 2024

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented Apr 15, 2024 •
edited
Loading

@wbrowne wbrowne added type/bug Something isn't working dependencies Pull requests that update a dependency file labels Apr 15, 2024
@wbrowne wbrowne self-assigned this Apr 15, 2024
@wbrowne wbrowne requested a review from a team as a code owner April 15, 2024 10:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 15, 2024 •
edited
Loading

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:f6e9e240bcdc0cdc8612607c77407878f587b381pre

aangelisc
aangelisc previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some lint related issues that need fixing before this could be merged

@wbrowne wbrowne requested a review from aangelisc April 15, 2024 11:36
aangelisc
aangelisc approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wbrowne!

@aangelisc aangelisc merged commit 1cda6c2 into main Apr 15, 2024
17 checks passed
@aangelisc aangelisc deleted the fix-pdc branch April 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

Assignees

@wbrowne wbrowne

Labels
dependencies Pull requests that update a dependency file type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbrowne @aangelisc