Skip to content

Commit

Permalink
StatPanel: Fixes data link tooltip not showing for single value (#34934)
Browse files Browse the repository at this point in the history
(cherry picked from commit d9e9e47)
  • Loading branch information
torkelo authored and grafanabot committed May 31, 2021
1 parent bfb3e90 commit 42e612e
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions packages/grafana-ui/src/components/BigValue/BigValue.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ export interface Props extends Themeable2 {
text?: TextDisplayOptions;
/** Specify which text should be visible in the BigValue */
textMode?: BigValueTextMode;
/** If true disables the tooltip */
hasLinks?: boolean;

/**
* If part of a series of stat panes, this is the total number.
Expand All @@ -73,16 +75,19 @@ export class BigValue extends PureComponent<Props> {
};

render() {
const { onClick, className } = this.props;
const { onClick, className, hasLinks } = this.props;
const layout = buildLayout(this.props);
const panelStyles = layout.getPanelStyles();
const valueAndTitleContainerStyles = layout.getValueAndTitleContainerStyles();
const valueStyles = layout.getValueStyles();
const titleStyles = layout.getTitleStyles();
const textValues = layout.textValues;

// When there is an outer data link this tooltip will override the outer native tooltip
const tooltip = hasLinks ? undefined : textValues.tooltip;

return (
<div className={className} style={panelStyles} onClick={onClick} title={textValues.tooltip}>
<div className={className} style={panelStyles} onClick={onClick} title={tooltip}>
<div style={valueAndTitleContainerStyles}>
{textValues.title && <div style={titleStyles}>{textValues.title}</div>}
<FormattedValueDisplay value={textValues} style={valueStyles} />
Expand Down

0 comments on commit 42e612e

Please sign in to comment.