Skip to content

Commit

Permalink
feat: support multiple alert in a panel
Browse files Browse the repository at this point in the history
  • Loading branch information
@okhowang
okhowang committed Dec 3, 2019
1 parent e216044 commit e4fcb85
Show file tree
Hide file tree
Showing 6 changed files with 300 additions and 252 deletions.
174 changes: 96 additions & 78 deletions pkg/services/alerting/extractor.go
View file
Expand Up @@ -99,108 +99,126 @@ func (e *DashAlertExtractor) getAlertFromPanels(jsonWithPanels *simplejson.Json,
continue
}

panelID, err := panel.Get("id").Int64()
if err != nil {
return nil, ValidationError{Reason: "A numeric panel id property is missing"}
if list, err := jsonAlert.Array(); err == nil {
for i := range list {
alert, err := e.getAlertFromAlert(jsonAlert.GetIndex(i), panel, validateAlertFunc)
if err != nil {
return nil, err
}
alerts = append(alerts, alert)
}
} else {
alert, err := e.getAlertFromAlert(jsonAlert, panel, validateAlertFunc)
if err != nil {
return nil, err
}
alerts = append(alerts, alert)
}
}

// backward compatibility check, can be removed later
enabled, hasEnabled := jsonAlert.CheckGet("enabled")
if hasEnabled && !enabled.MustBool() {
continue
}
return alerts, nil
}

func (e *DashAlertExtractor) getAlertFromAlert(jsonAlert, panel *simplejson.Json, validateAlertFunc func(*models.Alert) bool) (*models.Alert, error) {
panelID, err := panel.Get("id").Int64()
if err != nil {
return nil, ValidationError{Reason: "A numeric panel id property is missing"}
}

// backward compatibility check, can be removed later
enabled, hasEnabled := jsonAlert.CheckGet("enabled")
if hasEnabled && !enabled.MustBool() {
return nil, nil
}

frequency, err := getTimeDurationStringToSeconds(jsonAlert.Get("frequency").MustString())
if err != nil {
return nil, ValidationError{Reason: err.Error()}
}

frequency, err := getTimeDurationStringToSeconds(jsonAlert.Get("frequency").MustString())
rawFor := jsonAlert.Get("for").MustString()
var forValue time.Duration
if rawFor != "" {
forValue, err = time.ParseDuration(rawFor)
if err != nil {
return nil, ValidationError{Reason: err.Error()}
return nil, ValidationError{Reason: "Could not parse for"}
}
}

rawFor := jsonAlert.Get("for").MustString()
var forValue time.Duration
if rawFor != "" {
forValue, err = time.ParseDuration(rawFor)
if err != nil {
return nil, ValidationError{Reason: "Could not parse for"}
}
}
alert := &models.Alert{
DashboardId: e.Dash.Id,
OrgId: e.OrgID,
PanelId: panelID,
Id: jsonAlert.Get("id").MustInt64(),
Name: jsonAlert.Get("name").MustString(),
Handler: jsonAlert.Get("handler").MustInt64(),
Message: jsonAlert.Get("message").MustString(),
Frequency: frequency,
For: forValue,
}

alert := &models.Alert{
DashboardId: e.Dash.Id,
OrgId: e.OrgID,
PanelId: panelID,
Id: jsonAlert.Get("id").MustInt64(),
Name: jsonAlert.Get("name").MustString(),
Handler: jsonAlert.Get("handler").MustInt64(),
Message: jsonAlert.Get("message").MustString(),
Frequency: frequency,
For: forValue,
}
for _, condition := range jsonAlert.Get("conditions").MustArray() {
jsonCondition := simplejson.NewFromAny(condition)

for _, condition := range jsonAlert.Get("conditions").MustArray() {
jsonCondition := simplejson.NewFromAny(condition)
jsonQuery := jsonCondition.Get("query")
queryRefID := jsonQuery.Get("params").MustArray()[0].(string)
panelQuery := findPanelQueryByRefID(panel, queryRefID)

jsonQuery := jsonCondition.Get("query")
queryRefID := jsonQuery.Get("params").MustArray()[0].(string)
panelQuery := findPanelQueryByRefID(panel, queryRefID)
if panelQuery == nil {
reason := fmt.Sprintf("Alert on PanelId: %v refers to query(%s) that cannot be found", alert.PanelId, queryRefID)
return nil, ValidationError{Reason: reason}
}

if panelQuery == nil {
reason := fmt.Sprintf("Alert on PanelId: %v refers to query(%s) that cannot be found", alert.PanelId, queryRefID)
return nil, ValidationError{Reason: reason}
}
dsName := ""
if panelQuery.Get("datasource").MustString() != "" {
dsName = panelQuery.Get("datasource").MustString()
} else if panel.Get("datasource").MustString() != "" {
dsName = panel.Get("datasource").MustString()
}

dsName := ""
if panelQuery.Get("datasource").MustString() != "" {
dsName = panelQuery.Get("datasource").MustString()
} else if panel.Get("datasource").MustString() != "" {
dsName = panel.Get("datasource").MustString()
}
datasource, err := e.lookupDatasourceID(dsName)
if err != nil {
e.log.Debug("Error looking up datasource", "error", err)
return nil, ValidationError{Reason: fmt.Sprintf("Data source used by alert rule not found, alertName=%v, datasource=%s", alert.Name, dsName)}
}

datasource, err := e.lookupDatasourceID(dsName)
if err != nil {
e.log.Debug("Error looking up datasource", "error", err)
return nil, ValidationError{Reason: fmt.Sprintf("Data source used by alert rule not found, alertName=%v, datasource=%s", alert.Name, dsName)}
}
dsFilterQuery := models.DatasourcesPermissionFilterQuery{
User: e.User,
Datasources: []*models.DataSource{datasource},
}

dsFilterQuery := models.DatasourcesPermissionFilterQuery{
User: e.User,
Datasources: []*models.DataSource{datasource},
if err := bus.Dispatch(&dsFilterQuery); err != nil {
if err != bus.ErrHandlerNotFound {
return nil, err
}

if err := bus.Dispatch(&dsFilterQuery); err != nil {
if err != bus.ErrHandlerNotFound {
return nil, err
}
} else {
if len(dsFilterQuery.Result) == 0 {
return nil, models.ErrDataSourceAccessDenied
}
} else {
if len(dsFilterQuery.Result) == 0 {
return nil, models.ErrDataSourceAccessDenied
}
}

jsonQuery.SetPath([]string{"datasourceId"}, datasource.Id)

if interval, err := panel.Get("interval").String(); err == nil {
panelQuery.Set("interval", interval)
}
jsonQuery.SetPath([]string{"datasourceId"}, datasource.Id)

jsonQuery.Set("model", panelQuery.Interface())
if interval, err := panel.Get("interval").String(); err == nil {
panelQuery.Set("interval", interval)
}

alert.Settings = jsonAlert
jsonQuery.Set("model", panelQuery.Interface())
}

// validate
_, err = NewRuleFromDBAlert(alert)
if err != nil {
return nil, err
}
alert.Settings = jsonAlert

if !validateAlertFunc(alert) {
return nil, ValidationError{Reason: fmt.Sprintf("Panel id is not correct, alertName=%v, panelId=%v", alert.Name, alert.PanelId)}
}
// validate
_, err = NewRuleFromDBAlert(alert)
if err != nil {
return nil, err
}

alerts = append(alerts, alert)
if !validateAlertFunc(alert) {
return nil, ValidationError{Reason: fmt.Sprintf("Panel id is not correct, alertName=%v, panelId=%v", alert.Name, alert.PanelId)}
}

return alerts, nil
return alert, nil
}

func validateAlertRule(alert *models.Alert) bool {
Expand Down

0 comments on commit e4fcb85

Please sign in to comment.