Strict null fixes: updates return type of getMessageFromError, fixes …

…QueryOperationAction props (#24690) * Chore: updates getMessageFromError return type * Chore: updates the position of incorrectly placed bang operator * Chore: updates typing on dropdown typeahead directive * Chore: updates QueryOperationAction props to require title * Revert "Chore: updates QueryOperationAction props to require title"
grafana · May 14, 2020 · ee12f5e · ee12f5e
1 parent 25e1238
commit ee12f5e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/public/app/core/components/PermissionList/AddPermission.tsx b/public/app/core/components/PermissionList/AddPermission.tsx
@@ -64,7 +64,7 @@ class AddPermissions extends Component<Props, NewDashboardAclItem> {
   };
 
   onPermissionChanged = (permission: SelectableValue<PermissionLevel>) => {
-    this.setState({ permission: permission!.value });
+    this.setState({ permission: permission.value! });
   };
 
   onSubmit = async (evt: React.SyntheticEvent) => {

diff --git a/public/app/core/directives/dropdown_typeahead.ts b/public/app/core/directives/dropdown_typeahead.ts
@@ -44,7 +44,7 @@ export function dropdownTypeahead($compile: any) {
 
       const typeaheadValues = _.reduce(
         $scope.menuItems,
-        (memo, value, index) => {
+        (memo: any[], value, index) => {
           if (!value.submenu) {
             value.click = 'menuItemSelected(' + index + ')';
             memo.push(value.text);
@@ -184,7 +184,7 @@ export function dropdownTypeahead2($compile: any) {
 
       const typeaheadValues = _.reduce(
         $scope.menuItems,
-        (memo, value, index) => {
+        (memo: any[], value, index) => {
           if (!value.submenu) {
             value.click = 'menuItemSelected(' + index + ')';
             memo.push(value.text);

diff --git a/public/app/core/utils/errors.ts b/public/app/core/utils/errors.ts
@@ -1,6 +1,6 @@
 import _ from 'lodash';
 
-export function getMessageFromError(err: string | (Error & { data?: any; statusText?: string })): string | null {
+export function getMessageFromError(err: string | (Error & { data?: any; statusText?: string })): string {
   if (err && !_.isString(err)) {
     if (err.message) {
       return err.message;