Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: Permissions list #10747

Closed
torkelo opened this issue Feb 3, 2018 · 12 comments
Closed

UX: Permissions list #10747

torkelo opened this issue Feb 3, 2018 · 12 comments
Assignees
@Ijin08
Labels
type/ux
Projects
Issue preparations
Milestone
5.1-beta1

Comments

@torkelo
Copy link
Member

torkelo commented Feb 3, 2018

Would be nice to get user & team avatars in this list as well as user full name (only showing login/username currently).

The Icon is the only thing that separates Users from Teams. Maybe we need a label instead? Team: User: and then we can use the avatar img instead.

screen shot 2018-02-03 at 09 58 13

thoughts @mattttt ? @Ijin08 can you do a mockup?
@torkelo torkelo added the type/ux label Feb 3, 2018
@torkelo torkelo added this to UX Design in Issue preparations Feb 3, 2018
@Ijin08
Copy link
Contributor

Ijin08 commented Feb 5, 2018 •
edited

This was a bit tricky. I tried Team: and User: which didn't turn out so good:
permissions_mockup_no
permissions_mockup_no2

Instead I put user/team after(I prefer the second one):
permissions_mockup_v1
permissions_mockup_v2

@marefr
Copy link
Member

marefr commented Feb 5, 2018

Hmm tricky. Maybe easier/nicer if we add sections in table dividing users and teams?

@torkelo
Copy link
Member Author

torkelo commented Feb 5, 2018

thoughts @mattttt ?

@Ijin08
Copy link
Contributor

Ijin08 commented Feb 5, 2018 •
edited

That isn't a bad idea:
permissions_mockup_v4
permissions_mockup_v3

I think the one without icons is the better one.

@Ijin08
Copy link
Contributor

Ijin08 commented Feb 5, 2018

permissions_mockup_v5

@marefr
Copy link
Member

marefr commented Feb 5, 2018

Agree

@mattttt
Copy link
Contributor

mattttt commented Feb 9, 2018

I havent had the time yet to build an alternate mockup, however a few notes on the latest.

The blue text is sometime used for links, in other cases we use it for emphasis (query editors). It looks good, and jumps off the page, but on this page in particular, it feels like there isnt consistency.

I suggest we leave it for Viewer and Can, and we try a different header style for the sections and explore the same style as the bold, white text used for "Add Permissions For:" in the add box above?

Want to play with this a bit, as I think it'll be a convention we use elsewhere.

@Ijin08
Copy link
Contributor

Ijin08 commented Feb 9, 2018 •
edited

Great feedback @mattttt
Changed the blue color. I leave this too you so looking forward to see what you come up with.
permissions_mockup_v6

@Ijin08
Copy link
Contributor

Ijin08 commented Feb 9, 2018 •
edited

Torkel wanted me to try on more thing:
permissions_mockup_v8

Edit: Added some icons.

@torkelo
Copy link
Member Author

torkelo commented Feb 9, 2018

Think I prefer that over all the other options, things align more and becomes easier to parse . Needs icons for the different roles :) We can still sort so that all team rules are listed together before User rules etc.

@Ijin08
Copy link
Contributor

Ijin08 commented Feb 12, 2018

permissions_mockup_v9

torkelo added a commit that referenced this issue Feb 14, 2018
@torkelo
wip: dashboard acl ux2, #10747
73eaba0
@torkelo torkelo added this to the 5.1 milestone Feb 20, 2018
@torkelo torkelo moved this from UX Design to Ready For Implementation in Issue preparations Feb 20, 2018
@torkelo
Copy link
Member Author

torkelo commented Feb 22, 2018

I have started some initial work on this in this branch, https://github.com/grafana/grafana/compare/dashboard-acl-ux2

@Ijin08 can you take over (checkout the above branch)

@bergquist bergquist modified the milestones: 5.1, 5.2 Mar 22, 2018
@Ijin08 Ijin08 mentioned this issue Mar 28, 2018
Merged
@marefr marefr modified the milestones: 5.2, 5.1 Apr 17, 2018
Issue preparations automation moved this from Ready For Implementation to Done Apr 17, 2018
marefr added a commit that referenced this issue Apr 17, 2018
@marefr
changelog: notes about closing #10747
ffe9b42 
[skip ci]
ryantxu added a commit to NatelEnergy/grafana that referenced this issue Apr 18, 2018
@ryantxu
Merge remote-tracking branch 'grafana/master'
fd75d59 
* grafana/master: (52 commits)
  changelog: adds note for grafana#11173
  changelog: fix typo
  changelog: notes about closing grafana#11572
  Fix issues with metric reporting (grafana#11518)
  changelog: notes about closing grafana#10747
  fix: Row state is now ignored when looking for dashboard changes (grafana#11608)
  disable codecov comments
  add some more sort order asserts for permissions store tests
  Revert "build: remove code cov"
  Revert "removes codecov from frontend tests"
  tsdb: update query and annotation editor help texts for postgres
  changelog: notes about closing grafana#11578
  calculate datetime for timeFrom and timeTo macro in go
  set default for sslmode to verify-full in postgres datasource editor (grafana#11615)
  add some more sort order asserts for permissions store tests
  fix unconvert issues
  variable: fix binding bug after ts conversion
  add GetFromAsTimeUTC and GetToAsTimeUTC and use them in timeFilter macro
  fix merge conflict
  remove changes to module.ts from this branch
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ijin08 Ijin08

Labels
type/ux
Projects
No open projects
Issue preparations
  
Done
Milestone
5.1-beta1
Development

No branches or pull requests
5 participants
@torkelo @bergquist @marefr @mattttt @Ijin08