Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Improve save modal #10748

Closed
torkelo opened this issue Feb 3, 2018 · 8 comments · Fixed by #11822
Closed

UX: Improve save modal #10748

torkelo opened this issue Feb 3, 2018 · 8 comments · Fixed by #11822
Assignees
Labels
Milestone

Comments

@torkelo
Copy link
Member

torkelo commented Feb 3, 2018

  • make leaving a note optional (do not show input field)
  • save current time range
  • save current variables
@torkelo torkelo added the type/ux label Feb 3, 2018
@torkelo torkelo added this to the 5.0 milestone Feb 3, 2018
@torkelo
Copy link
Member Author

torkelo commented Feb 5, 2018

related #8805

@Ijin08
Copy link
Contributor

Ijin08 commented Feb 5, 2018

So my idea at the moment is to add a options button that expands the modal to show the different options:
save_modal_closed
save_modal_open

@mattttt
Copy link
Contributor

mattttt commented Feb 5, 2018

I think this makes a lot of sense.

Originally though the options opening above the button (on click) is an anti-pattern, though it's just as odd to show the options below and split up the button row.

Let's go ahead and build this as @Ijin08 proposes above, use it, and see how we can iterate accordingly.

@Ijin08
Copy link
Contributor

Ijin08 commented Feb 6, 2018

Felt the need to explore this option as well:
save_modal_tabs

@Ijin08
Copy link
Contributor

Ijin08 commented Feb 6, 2018

save_modal_tabs_quick

save_modal_tabs_options

@torkelo torkelo modified the milestones: 5.0, 5.1 Feb 13, 2018
@kfdm
Copy link
Contributor

kfdm commented Feb 20, 2018

Having options to save (or not save) the current time range and current variables is quite a nice improvement ! I know that will help make things easier with some of my usage.

Though I am curious why there is a need to move things to an Options tab. While I understand wanting to reduce clutter, I wonder if everything on the same tab and just letting the user submit without filling anything out (perhaps add (optional) into the placeholder text) would be a simpler way to handle it.

@bergquist bergquist modified the milestones: 5.1, 5.2 Mar 22, 2018
@Ijin08
Copy link
Contributor

Ijin08 commented Apr 11, 2018

Talked with @mattttt a while back about this and we are thinking of having a modal with short message and buttons for save, options and cancel. Hitting options will close modal and open new one in a appealing way.

savemodal_v3closedoptions

savemodal_v3openoptions

@torkelo , @mattttt , @davkal thoughts?

@kfdm
Copy link
Contributor

kfdm commented Apr 11, 2018

Just an outside opinion, but I think using the second dialog only would provide a better flow. By hiding the note box behind options, it's much less likely that users will bother filling it out. By leaving everything on the same dialog, but making it optional, users that don't want to add a note can just skip it while making it easy to add a note if you want. Leaving both options (time range and variables) unchecked by default seems reasonable.

In a more involved operation, having a separate options dialog makes sense, but I feel like in this case, it adds an unnecessary extra step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants