Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: OpenTSDB use interval variable for downsampling #1242

Closed
RalfGraefeIntel opened this issue Dec 16, 2014 · 3 comments
Closed

Comments

@RalfGraefeIntel
Copy link

Hello,

For OpenTSDB I would like to use interval template variables for the DownSample field. This should hopefully allow to dynamically downsample the result set based on zoom level.

Looking at the code I could imagine that its as simple as that (but I'm not a JavaScript expert):
in src/app/services/opentsdb/opentsdbDatasource.js line 152
replace
query.downsample = target.downsampleInterval + "-" + target.downsampleAggregator;
with
query.downsample = templateSrv.replace(target.downsampleInterval) + "-" + target.downsampleAggregator;

Could that work? I wanted to test myself but could not get the grunt command to run :[ .
In addition an autocomplete function that only lists variables of type interval would be nice.
grafana_interval

using in downsample:

grafana-downsample

Thanks

@torkelo
Copy link
Member

torkelo commented Dec 16, 2014

Yes, this is a very simple enhancement to implement. Will add this to 1.9.1 patch release and implemented tomorrow.

@toni-moreno
Copy link
Contributor

Hi @torkelo . As I told you some weeks ago in (#914 (comment))

This downsampling feature depending on the time range ( and the consolidation function related to each metric ) should be a common feature with independence of the data backend .

I'll be pleased to discuss on this issue again if needed.

@RalfGraefeIntel
Copy link
Author

Hi Torkel,

Thanks for the quick reply. I’m looking forward to this release.

Ralf

From: Torkel Ödegaard [mailto:notifications@github.com]
Sent: Tuesday, December 16, 2014 9:10 PM
To: grafana/grafana
Cc: Graefe, Ralf
Subject: Re: [grafana] Feature Request: OpenTSDB use interval variable for downsampling (#1242)

Yes, this is a very simple enhancement to implement. Will add this to 1.9.1 patch release and implemented tomorrow.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1242#issuecomment-67223308.
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

torkelo added a commit that referenced this issue Jan 25, 2015
…hange now to be for example now-1m, usefull when you want to ignore last minute because it contains incomplete data, Closes #1242, Closes #374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants