Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row drag handle is shown even though editing is disabled #13555

Closed
timyllym opened this issue Oct 8, 2018 · 4 comments
Closed

Row drag handle is shown even though editing is disabled #13555

timyllym opened this issue Oct 8, 2018 · 4 comments

Comments

@timyllym
Copy link

timyllym commented Oct 8, 2018

When row is collapsed it shows a drag handle on the right edge for moving row. I think this handle shouldn’t be visible when editing is disabled because it gives a wrong signal to user.

Grafana 5.2
MacOS High Sierra
Google Chrome 69.0.3497.100

@torkelo
Copy link
Member

torkelo commented Oct 8, 2018

Here is the drag handle , and you a canEdit check above to use as reference:

https://github.com/grafana/grafana/blob/master/public/app/features/dashboard/dashgrid/DashboardRow.tsx#L115

@timyllym
Copy link
Author

timyllym commented Oct 8, 2018

Ok, I can make a PR. I can't make a new branch though.

@praveensastry
Copy link
Contributor

I would like to work on this

@marefr
Copy link
Member

marefr commented Oct 15, 2018

Fixed in #13568

@marefr marefr closed this as completed Oct 15, 2018
marefr added a commit that referenced this issue Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants