Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore: query field typeahead is DOM-dependent #13714

Closed
davkal opened this issue Oct 17, 2018 · 1 comment
Closed

Explore: query field typeahead is DOM-dependent #13714

davkal opened this issue Oct 17, 2018 · 1 comment
Labels
area/explore prio/low It's a good idea, but not scheduled for any release type/refactor

Comments

@davkal
Copy link
Contributor

davkal commented Oct 17, 2018

Currently the typeahead detects the query context with help from CSS classes of the span that has the cursor. (The CSS classes were applied from the syntax highlighting containing the grammar rules.)
Using DOM attributes is suboptimal for testing typeahead.

Evaluate a way to use a slate-only way that can figure out the context (e.g., via marks).
@gabor gabor added type/refactor prio/low It's a good idea, but not scheduled for any release labels Jun 9, 2021
@aocenas
Copy link
Member

aocenas commented Nov 11, 2021

Closing this as we are moving to monaco

@aocenas aocenas closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/explore prio/low It's a good idea, but not scheduled for any release type/refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabor @davkal @aocenas