Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When datasource returns 'none' as unit it should be possible to change unit in panel #13718

Closed
dimrozakis opened this issue Oct 17, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@dimrozakis
Copy link

commented Oct 17, 2018

What Grafana version are you using?

5.3.0

What datasource are you using?

CloudWatch

What did you do?

Upgraded grafana to 5.3.0 and visited one of my dashboards displaying S3 metrics from CloudWatch. All units that were previously manually configured were automatically converted to 'none'. When I tried to set them manually again, they'd automatically revert back to 'none'.

What was the expected result?

Either properly autodiscover units, or allow me to manually set them.

More context

This was caused by #13571. See #13571 (comment).

The main issue here is that if the autodiscovered unit is 'none', it shouldn't be forced on the UI. Maybe the user knows better what the unit is, or maybe they prefer it as 'short' instead.

It'd also be worth investigating why S3 metric units are not being discovered.

@dimrozakis dimrozakis changed the title Don't force Don't force 'none' unit for cloudwatch Oct 17, 2018

@marefr marefr added this to the 5.3.2 milestone Oct 17, 2018

@marefr marefr changed the title Don't force 'none' unit for cloudwatch When datasource returns 'none' as unit it should be possible to change unit in panel Oct 18, 2018

marefr added a commit that referenced this issue Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.