Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofitpanels does not respect header any more #15650

Closed
kschlesselmann opened this issue Feb 26, 2019 · 4 comments · Fixed by #15767
Closed

autofitpanels does not respect header any more #15650

kschlesselmann opened this issue Feb 26, 2019 · 4 comments · Fixed by #15767

Comments

@kschlesselmann
Copy link

After upgrading to grafana 6.0.0 our dashboards contain scrollbars.

It seems that the header bar shown with kiosk=tv isn't used in the computations that are done during autofitpanels any more.

@jschill
Copy link
Contributor

jschill commented Feb 26, 2019

We've changed the component used for scrolling, which might have caused some side effect, but when I have Grafana 5.5 and 6.0 side by side I don't see any difference except the scrollbar design.

  • What browser+version & os are you using?
  • What version did you upgrade from?
  • What is your journey to your dashboard? Do you click? Use a bookmark?
  • Urls and screenshots are super helpful if possible.

One thing to note about the scrollbars if you're on MacOS is there's a setting in System Preferences > General called "Show scroll bars" that might make the scrollbars look different on different machines depending on your setting.

@jschill jschill added the needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc label Feb 26, 2019
@covrig
Copy link

covrig commented Feb 27, 2019

Same here (for kiosk=tv). The height is larger than the screen.
I just updated the Docker container from 6.0.0 B1 to 6.0.0. Downgrading solves the problem.
I see this on Windows (Chrome and IE) and Linux, no matter the journey to the dashboard.

@kschlesselmann
Copy link
Author

@jschill I'm sorry I cannot provide any screenshots of our dashboards.
All team members here experience the same behaviour though. So there's at least Win 10, Debian, Ubuntu, Manjaro and Arch involved with Fireforx, Chromium and Chrome.

Our installation updates nightly to the latest docker image.

Our journey to the dashbord is always a bookmark (we use scripted dashboards here)

The url looks like https://.../dashboard/script/dashboard-1.js?environment=develop&orgId=1&refresh=30s&kiosk=tv&autofitpanels

Basically I'd say we experience the same behaviour as @covrig

Hope that's detail enough.

@jschill jschill added area/frontend and removed needs more info Issue needs more information, like query results, dashboard or panel json, grafana version etc labels Mar 4, 2019
@marefr marefr added this to the 6.0.1 milestone Mar 4, 2019
marefr added a commit that referenced this issue Mar 4, 2019
@jschill
Copy link
Contributor

jschill commented Mar 5, 2019

Thanks for reporting and input, @kschlesselmann && @covrig

torkelo pushed a commit that referenced this issue Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants