Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forcing decimal precision in singlestat panel doesn't work #16373

Closed
paulfantom opened this issue Apr 3, 2019 · 4 comments
Closed

Forcing decimal precision in singlestat panel doesn't work #16373

paulfantom opened this issue Apr 3, 2019 · 4 comments
Labels
area/panel/singlestat type/bug
Milestone
6.1.3

Comments

@paulfantom
Copy link
Contributor

What happened:
Singlestat panel stopped rounding number to specified decimal precision.

What you expected to happen:
singlestat panel respects specified precision

How to reproduce it (as minimally and precisely as possible):
Create a singlestat panel and change decimal precision from "auto" to some number.

Anything else we need to know?:

What I got:
wrong

What happens after setting precision to auto:
okayish

In previous Grafana version it was showing correctly rounded value.

Environment:

  • Grafana version: 6.1.0
  • Data source type & version: Prometheus (version 2.8.1)
  • OS Grafana is installed on: official docker container deployed on fedora 29 server
  • User OS & Browser: Fedora 29, Chrome 73.0.3683.86
  • Grafana plugins: same as in official docker image, nothing added
  • Others: Tested on following dashboard: https://grafana.com/dashboards/1860
@thomas-netric
Copy link

I got the same issue for data source: mysql

@djg2002
Copy link

djg2002 commented Apr 4, 2019

We amended the offending panels to '0' decimal places but they now show 2 decimal places. If we set any other (positive) integer it always shows 9 decimal places.

  • Grafana version: 6.1.0 (upgraded from 6.0.2)
  • Datasource: Elasticsearch 6.3.1 (configured as 6.0+ in datasource)
  • OS Grafana is installed on: official docker container, Debian
  • OS / Browser: Windows 10, Linux Ubuntu, MacOS / Chrome

torkelo added a commit that referenced this issue Apr 5, 2019
@torkelo
Units: Correctly use the override decimals
fdba9c8 
Fixes bugs introduced in PR #14716 and #15146 also restores unit tests that where lost in the
move from kbn units to @grafana/ui units

Fixes #16068
Fixes #16373
@torkelo torkelo mentioned this issue Apr 5, 2019
Merged
@torkelo torkelo added this to the 6.1.2 milestone Apr 5, 2019
This was referenced Apr 7, 2019
Closed
Closed
torkelo added a commit that referenced this issue Apr 7, 2019
@torkelo
Units: Correctly use the override decimals (#16413)
8a4a6b4 
Fixes bugs introduced in PR #14716 and #15146 also restores unit tests that where lost in the
move from kbn units to @grafana/ui units

Fixes #16068
Fixes #16373
@torkelo torkelo mentioned this issue Apr 8, 2019
Closed
torkelo added a commit that referenced this issue Apr 8, 2019
@torkelo
Units: Correctly use the override decimals (#16413)
da0302f 
Fixes bugs introduced in PR #14716 and #15146 also restores unit tests that where lost in the
move from kbn units to @grafana/ui units

Fixes #16068
Fixes #16373

(cherry picked from commit 8a4a6b4)
@thomas-netric
Copy link

I just upgraded to 6.1.2 and I'm still experiencing the same issues.

@torkelo
Copy link
Member

torkelo commented Apr 8, 2019

Damit I missed part of the fix :(

Opening new PR with the next part of the fix asap.

@torkelo torkelo reopened this Apr 8, 2019
@torkelo torkelo modified the milestones: 6.1.2, 6.1.3 Apr 8, 2019
torkelo added a commit that referenced this issue Apr 8, 2019
@torkelo
Singlestat: Use decimal override when manually specified
a2dcbde 
Fixes #16373
@torkelo torkelo mentioned this issue Apr 8, 2019
Merged
torkelo added a commit that referenced this issue Apr 8, 2019
@torkelo
Singlestat: Use decimal override when manually specified (#16451)
b46b84f 
Fixes #16373
torkelo added a commit that referenced this issue Apr 9, 2019
@torkelo
Singlestat: Use decimal override when manually specified (#16451)
be84bff 
Fixes #16373

(cherry picked from commit b46b84f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/panel/singlestat type/bug
Projects
None yet
Milestone
6.1.3
Development

No branches or pull requests
4 participants
@torkelo @djg2002 @paulfantom @thomas-netric