Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom panel defaults and overrides in new react panels #16576

Closed
ryantxu opened this issue Apr 14, 2019 · 3 comments
Closed

Support custom panel defaults and overrides in new react panels #16576

ryantxu opened this issue Apr 14, 2019 · 3 comments
Labels
area/panel/common stale Issue with no recent activity

Comments

@ryantxu
Copy link
Member

ryantxu commented Apr 14, 2019

There has been a lot of discussion around how to support standard settings and templates. I think this is part of that solution, not the entire thing.

It would be great to be able to configure how the panel behaves by default across all dashboards. Also having custom versions of the panel options depending on the Field and SeriesData we are looking at. I propose:

  1. add a config tab on the panel plugin page that lets you set default options. These options would be stored in something like the datasource jsonData and along with the grafanaBootData
  2. add a general way to configure overrides for panel options
  3. The panel plugin is passed options that are derived from: plugin default + system defaults + panel config

The config page could look something like this:
image

@ryantxu
Copy link
Member Author

ryantxu commented Apr 14, 2019

This would also require (or at least be better) if the Options UIs are built in a way that could consistently shows you want the default value are and if your values are different.

  • placeholder works well for things in text fields
  • dropdown using <Select/> has many nice style options that can show this
  • not sure how to show it with switch components though :) maybe the color of the selection background and a tooltip?

Perhaps when building the save model, it checks values vs the default and only saves things that are different.

@stale
Copy link

stale bot commented Dec 2, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue with no recent activity label Dec 2, 2019
@ryantxu
Copy link
Member Author

ryantxu commented May 11, 2021

this is resolved

@ryantxu ryantxu closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/panel/common stale Issue with no recent activity
Projects
None yet
Development

No branches or pull requests

2 participants