Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlists based on tags stopped working #16704

Closed
omelnyk1 opened this issue Apr 22, 2019 · 3 comments 路 Fixed by #16727
Closed

Playlists based on tags stopped working #16704

omelnyk1 opened this issue Apr 22, 2019 · 3 comments 路 Fixed by #16727

Comments

@omelnyk1
Copy link

What happened:
A playlist created on tags stopped working and shows only first dashboard without switching.
What you expected to happen:
Playlist works like a charm 馃槃
How to reproduce it (as minimally and precisely as possible):

  1. Create new playlist
  2. Add dashboards using tags
  3. Run playlist

Environment:

  • Grafana version: 6.1.4 (fef1733)
  • OS Grafana is installed on: CentOS 6.10
  • User OS & Browser: MacOS Mojave 10.14.3, Safari/Firefox, Windows 10 IE
@omelnyk1
Copy link
Author

@torkelo could you please have a look?
Thanks in advance.

@marefr
Copy link
Member

marefr commented Apr 23, 2019

Confirmed bug since Grafana v6.1.0. Thanks for the report

@marefr marefr added this to the 6.1.5 milestone Apr 23, 2019
@jschill
Copy link
Contributor

jschill commented Apr 23, 2019

The JSON object returned from the playlist api has a Url param with an ending slash /.

Url: m.GetDashboardUrl(item.Uid, item.Slug),

(populateDashboardsByID does not return an ending slash. It is only populateDashboardsByTag)

When the client is comparing the returned Url param with the location in the state they are not equal and because of that the playlist is stopped.

if (state.location.path !== this.validPlaylistUrl) {

marefr added a commit that referenced this issue Apr 24, 2019
bergquist pushed a commit to bergquist/grafana that referenced this issue Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants